Fix false positive for constrained NamedTuple self types#21546
Open
BHUVANSH855 wants to merge 3 commits into
Open
Fix false positive for constrained NamedTuple self types#21546BHUVANSH855 wants to merge 3 commits into
BHUVANSH855 wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
87d8ebe to
613358a
Compare
102c263 to
2fe2202
Compare
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21453
This PR fixes a false positive reported for methods on generic
NamedTupleclasses that use constrained type variables.Example:
Previously mypy incorrectly reported:
The issue occurred during self-type validation for tuple-backed
NamedTupletypes using constrainedTypeVars.This change adds a narrow special-case in the self-type checker to avoid the false positive while preserving existing subtype semantics.
Changes included:
mypy/checker.pytest-data/unit/check-selftype.testVerification:
python -m pytest -q mypy/test/testcheck.py -n0