docs: add Windows instructions for pomerge in translating guide#1862
docs: add Windows instructions for pomerge in translating guide#1862pranavchoudhary-tech wants to merge 2 commits into
Conversation
Documentation build overview
|
36bbc80 to
fc0c616
Compare
|
Ah, my apologies! I created this branch from my fork's I have just rebased and force-pushed to clean it up. It should only contain the Windows instructions for pomerge now. Let me know if everything looks good! |
zware
left a comment
There was a problem hiding this comment.
The commands look reasonable to me, assuming that pomerge is available and working the same way on Windows.
I haven't tried this out, I'm hoping you have run this successfully? :)
|
Thanks for the review and approval! Yes, I can confirm the standard shell commands ( |
|
@tomasr8 |
StanFromIreland
left a comment
There was a problem hiding this comment.
Can you please add the .. include:: /include/activate-tab.rst to the top of the file like we have elsewhere.
|
Done! Added the |
| git checkout HEAD -- . | ||
|
|
||
| rem Merge translations from temporary dir back in | ||
| pomerge --from "%TEMP%\old-po-files\**\*.po" --to "**\*.po" --clear |
There was a problem hiding this comment.
I can't test this, and I don't really know anything about this (hence the TODO note ;-), but I asked Claude to check for me and it said:
The command relies on the shell to expand ***.po into an actual list of files, but cmd.exe never expands wildcards and pomerge doesn't glob its arguments itself, so pomerge receives the literal pattern string and crashes trying to parse it as a PO file.
Is this correct?
Haha yeah I figured, sorry about that! I just wanted a temporary label so I could keep track of the issues :) Thanks for adding the label! |
Fixes #1783
This PR adds the missing Windows commands tab for the
pomergetranslation recovery tool, resolving theTODOintranslating.rst. The commands for Windows usexcopyandrmdirto achieve the same result as the Unixcpandrm.