Test object_hook and pickleability of some JSON components#154155
Open
dslavicek wants to merge 2 commits into
Open
Test object_hook and pickleability of some JSON components#154155dslavicek wants to merge 2 commits into
object_hook and pickleability of some JSON components#154155dslavicek wants to merge 2 commits into
Conversation
dslavicek
commented
Jul 19, 2026
dslavicek
commented
Contributor
- add test for object hook in JSONDecoder
- add test of pickleability of JsonDecodeError
picnixz
previously requested changes
Jul 19, 2026
| @@ -0,0 +1,14 @@ | |||
| import json | |||
Contributor
Author
There was a problem hiding this comment.
@encukou advised me not to put this in the file with decoder tests. I saw no existing dedicated file for testing pickling of things from the json module. Where do you propose placing the test?
Member
There was a problem hiding this comment.
Ah I see. I guess, it's fine then (I wasn't aware of the rationale so it was surprsing).
This comment was marked as off-topic.
This comment was marked as off-topic.
picnixz
changed the title
object_hook and pickleability of json decoders
picnixz
changed the title
object_hook and pickleability of json decodersobject_hook and pickleability of some JSON components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.