Test that ValueError is raised when vfsopen is passed an invalid mode#154008
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
tomasr8
reviewed
Jul 18, 2026
tomasr8
changed the title
ValueError is raised when vfsopen is passed an invalid mode
Change from double quotes to single quotes. Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
tomasr8
enabled auto-merge (squash)
July 19, 2026 07:38
tomasr8
reviewed
Jul 19, 2026
tomasr8
added
needs backport to 3.14
|
GH-154064 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-154065 is a backport of this pull request to the 3.14 branch. |
tomasr8
added a commit
that referenced
this pull request
Jul 19, 2026
…nvalid mode (GH-154008) (#154064) Test that `ValueError` is raised when `vfsopen` is passed an invalid mode (GH-154008) * ValueError with message test * Remove white space * Apply suggestions from code review Change from double quotes to single quotes. --------- (cherry picked from commit 9f5af27) Co-authored-by: Rayan <157278782+ravg998@users.noreply.github.com> Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures vfsopen called with invalid "mode" argument raises a ValueError with correct initial error message ("invalid mode...")