Skip to content

make the PR template visible when previewing.#150564

Open
KRRT7 wants to merge 2 commits into
python:mainfrom
KRRT7:make-PR-template-visible
Open

make the PR template visible when previewing.#150564
KRRT7 wants to merge 2 commits into
python:mainfrom
KRRT7:make-PR-template-visible

Conversation

@KRRT7
Copy link
Copy Markdown

@KRRT7 KRRT7 commented May 28, 2026

currently the PR template is commented out, hence it's not shown correctly by GitHub.

@KRRT7
Copy link
Copy Markdown
Author

KRRT7 commented May 28, 2026

Trivial changes (typo fixes, etc.) do not need a linked issue.

I think my changes fit.

@nedbat
Copy link
Copy Markdown
Member

nedbat commented May 28, 2026

I don't understand. The comment renders for me. Perhaps you mean something else.

image

@KRRT7
Copy link
Copy Markdown
Author

KRRT7 commented May 28, 2026

in the same way issue templates render when you click "New Issue"
Screenshot 2026-05-28 at 12 18 45 PM

Pull requests also have that same ability.

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

when it's fully commented as before, it won't render.

@KRRT7
Copy link
Copy Markdown
Author

KRRT7 commented May 28, 2026

thought I believe my current changes are incorrect after reading those docs, let me double check.

@KRRT7 KRRT7 changed the title make the PR template visible. make the PR template visible when previewing. May 28, 2026
@KRRT7
Copy link
Copy Markdown
Author

KRRT7 commented May 28, 2026

okay, looks like the feature I'm talking about is a beta / enterprise feature not sure, I definitely have used it in the past.

there is still a bug however, since everything is commented out, when you click on the preview tab, CPython Current template won't preview correctly
Screenshot 2026-05-28 at 12 34 31 PM
Screenshot 2026-05-28 at 12 35 27 PM

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants