gh-115119: Fix libmpdec detection when pkg-config files are missing#150502
Open
stratakis wants to merge 2 commits into
Open
gh-115119: Fix libmpdec detection when pkg-config files are missing#150502stratakis wants to merge 2 commits into
stratakis wants to merge 2 commits into
Conversation
…sing The fallback for systems with no mpdecimal .pc files used AC_LINK_IFELSE directly, which relied on LIBMPDEC_LIBS being set. On failure this was empty so the link test ran without -lmpdec. Use AC_CHECK_HEADER and AC_CHECK_LIB instead.
stratakis
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
15 tasks
Contributor
Author
|
Found when trying to test what configure options to add for my buildbots and I saw the _decimal module wasn't actually building on centos stream 9 and 10, because they ship mpdecimal 2.5.1, hence no .pc files. I followed the convention of other libraries. |
Member
|
Could you please add a news entry? |
skirpichev
approved these changes
May 27, 2026
Member
skirpichev
left a comment
skirpichev
left a comment
There was a problem hiding this comment.
LGTM (modulo news entry)
Thanks for fixing this, it was my fault to believe, that pkg-config support was introduced in v2.5.0. But it was v4.0.0.
(Tested with v2.5.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback for systems with no mpdecimal .pc files used AC_LINK_IFELSE directly, which relied on LIBMPDEC_LIBS being set. On failure this was empty so the link test ran without -lmpdec.
Use AC_CHECK_HEADER and AC_CHECK_LIB instead.
libmpdecsources #115119