feat(packagesettings): activate source field and add source_resolver PBI property - #1305
Open
LalatenduMohanty wants to merge 1 commit into
Conversation
…er` PBI property Uncomment the `source: SourceResolver | None` field on both `PackageSettings` and `VariantInfo`, add `SourceResolver` to the public API, and wire up a `PackageBuildInfo.source_resolver` property with variant-then-package fallback. This is the foundation for all downstream resolver-config wiring (Phases 2-9 of the new resolver config epic). Closes: python-wheel-build#1291 Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source: SourceResolver | Nonefield on bothPackageSettingsandVariantInfoSourceResolverfrom thefromager.packagesettingspublic APIPackageBuildInfo.source_resolverproperty with variant-then-package fallback (variant source if set, else package source, elseNone)This is the foundation for all downstream resolver-config wiring (Phases 2–9 of the new resolver config epic).
Closes: #1291
🤖 Generated with Claude Code