Skip to content

chore(tests): clarify type annotations#1810

Merged
nijel merged 6 commits into
masterfrom
ai-findings-autofix/social_core-tests-backends-test_saml.py
Jun 22, 2026
Merged

chore(tests): clarify type annotations#1810
nijel merged 6 commits into
masterfrom
ai-findings-autofix/social_core-tests-backends-test_saml.py

Conversation

@nijel

@nijel nijel commented Jun 22, 2026

Copy link
Copy Markdown
Member

This PR applies 5/5 suggestions from code quality AI findings.

nijel and others added 5 commits June 22, 2026 11:52
…opilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…opilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…opilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…opilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…opilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@nijel nijel changed the title Potential fixes for 5 code quality findings chore(tests): clarify type annotations Jun 22, 2026
@nijel nijel self-assigned this Jun 22, 2026
@nijel nijel marked this pull request as ready for review June 22, 2026 09:52
@nijel nijel enabled auto-merge (squash) June 22, 2026 09:52
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.61%. Comparing base (06e154a) to head (265f05c).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
social_core/tests/backends/test_saml.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
+ Coverage   84.41%   84.61%   +0.20%     
==========================================
  Files         342      342              
  Lines       12593    12715     +122     
  Branches      607      632      +25     
==========================================
+ Hits        10630    10759     +129     
+ Misses       1742     1729      -13     
- Partials      221      227       +6     
Flag Coverage Δ
unittests 84.61% <75.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nijel nijel disabled auto-merge June 22, 2026 10:37
@nijel nijel enabled auto-merge (squash) June 22, 2026 10:38
@nijel nijel merged commit 52471d3 into master Jun 22, 2026
36 of 37 checks passed
@nijel nijel deleted the ai-findings-autofix/social_core-tests-backends-test_saml.py branch June 22, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant