Un-deprecate getdata(); have it return an ImageLinearAccess object - #9883
Open
akx wants to merge 1 commit into
Open
Un-deprecate getdata(); have it return an ImageLinearAccess object#9883akx wants to merge 1 commit into
getdata(); have it return an ImageLinearAccess object#9883akx wants to merge 1 commit into
Conversation
Contributor
Author
|
Didn't think I'd bump into a PyPy bug implementing this, but here we are... pypy/pypy#5526 |
akx
force-pushed
the
image-getdata-linear-access
branch
from
August 21, 2026 11:44
d8ff245 to
ecf4175
Compare
akx
force-pushed
the
image-getdata-linear-access
branch
from
August 21, 2026 12:29
ecf4175 to
3756d89
Compare
akx
marked this pull request as ready for review
August 21, 2026 12:41
Member
|
Could you identify exactly what workaround you added for that, so that one day when the PyPy fix has propagated, we are able to remove it? |
radarhere
reviewed
Aug 22, 2026
|
|
||
| def test_getdata_does_not_expose_the_image_core() -> None: | ||
| hopper_data = hopper().getdata() | ||
| # "Weird" core bits are not exposed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #9292 to un-deprecate
getdata(), sinceget_flattened_data()is not a perfect replacement for linear access to image pixels given its upfront memory and time costs. (See #9292 (comment) for rationales.)Fixes #9261 (since
getdatanow returns a real, well-typed iterator/access object). Givenx.pylikepyright fails on
main:but is fine on this branch:
The optimizations from #9881 still help this too and don't conflict here.