fix(api): drop dead TEMPORAL_API_HOST/PORT settings#59
Open
Chouffe wants to merge 1 commit into
Open
Conversation
Settings.host and Settings.port were never read by any entry point — every bind is set on the uvicorn CLI (Dockerfile CMD, Makefile targets) — so setting TEMPORAL_API_PORT silently did nothing. Remove the fields and drop HOST/PORT from the README configuration list; the bind stays a deployment concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings.hostandSettings.portfromapi/src/temporal_model/api/settings.py— they were never read by any entry point (DockerfileCMD,make serve,make run-gpuall set the bind on the uvicorn CLI), soTEMPORAL_API_HOST/TEMPORAL_API_PORTsilently did nothing.HOST,PORTfrom the README configuration list (api/README.md).api/tests/test_settings.py.The bind stays a deployment concern (CLI flags / image CMD), per option 1 in the issue. The dated design spec (
docs/specs/2026-06-02-api-service-design.md) is left untouched as a historical record.Closes #54
Test Plan
make testinapi/— 164 passed, 1 skippedmake lintinapi/— cleangrep -rn TEMPORAL_API_HOST\|TEMPORAL_API_PORT— no references left outside the dated spec