Advance every training clock the compiled function reads - #105
Merged
jessegrabowski merged 2 commits intoAug 24, 2026
Merged
Conversation
A clock is read by the update expressions a schedule feeds rather than by the outputs, so collecting from the outputs alone left it at zero and pinned every schedule to its initial rate, which under a warmup is exactly zero. Closes pymc-devs#79
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 60 60
Lines 3011 3012 +1
=======================================
+ Hits 2935 2936 +1
Misses 76 76 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A schedule places itself in time by reading a
StepCounter, but nothing advanced that counter unless the training step came fromcompile_train. Build the updates yourself and compile withfunctionand the clock sat at zero, so the schedule returned its initial rate on every call -- under a warmup that rate is zero, and the network never moved while reporting a flat loss.functionnow threads the one-step advance for every clock the graph reads, alongside the RNG updates it already threads. A caller's ownupdatesentry still wins, which is how a clock gets pinned, and a pinned clock is exempt from the check that every clock agrees on its step count -- it isn't counting these steps, so it has nothing to agree with.Closes #79
Closes #106