Add max and average pooling, dispatched on every backend - #100
Merged
Conversation
Without it the pullback is an anonymous OpFromGraph, which registers against no type, so no backend can put a kernel behind the backward pass.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 97.43% 91.08% -6.35%
==========================================
Files 56 59 +3
Lines 2609 2850 +241
==========================================
+ Hits 2542 2596 +54
- Misses 67 254 +187 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A conv stack had nothing to downsample with.
MaxPool1D/MaxPool2DandAvgPool1D/AvgPool2Dreduce the same windows a convolution correlates over, so they reuse the gather rather than repeating it, and each backend pools with its own primitive.Max pooling deliberately departs from pytensor's
maxgradient.pt.maxroutes the full cotangent to every tap tied for the maximum, so a window returns more gradient than it received — and after a rectifier, whole windows of ties are routine rather than measure-zero. Selecting throughargmaxgives it to one tap, as jax and torch do. mlx splits it evenly instead, so the backend tests assert the gradient is conserved rather than where it lands.