Skip to content

ci: Give each matrix leg its own ccache key - #200

Merged
DanielKellerM merged 1 commit into
pulp-platform:develfrom
DanielKellerM:ci/ccache-per-suite
Aug 17, 2026
Merged

ci: Give each matrix leg its own ccache key#200
DanielKellerM merged 1 commit into
pulp-platform:develfrom
DanielKellerM:ci/ccache-per-suite

Conversation

@DanielKellerM

Copy link
Copy Markdown
Collaborator

Second defect from #198, found by reading the devel logs after #199 landed.

#199 fixed the compiler prefix - the logs now show ccache g++-14 ... - but the cache still could not persist:

Failed to save: Unable to reserve cache with key ccache-simulate-4d88f80d...

github.job is the job id, identical for every matrix leg, so all six simulation legs used one key and raced. One saved, five failed. The five that failed would also have restored a different suite's objects on the next run.

Verified across the legs of one run - same key on all of them:

leg key
simulate (transpose_midend) ccache-simulate-4d88f80d...
simulate (mxclear) ccache-simulate-4d88f80d...
simulate (mxquant) ccache-simulate-4d88f80d...
simulate (mxroundtrip) ccache-simulate-4d88f80d...
simulate (transpose) ccache-simulate-4d88f80d...

The key now comes from the matrix value (sim-<suite>, elab-<id>), passed in as an action input since a composite action cannot read matrix itself.

Intra-job caching already works: mxquant reported Hits: 16 / 156 (10.26%) on a cold cache, the five widths sharing common objects. Cross-run hits need this fix plus one more run.

github.job is the job id, so all six simulation legs and all eight elaboration
legs keyed their cache identically. They then raced to save it: one won and the
rest reported "Unable to reserve cache with key ccache-simulate-<sha>", so five
of six suites stored nothing and would restore another suite's objects.

The key comes from the matrix value now, passed into the composite action,
which cannot see the matrix itself.
Copilot AI lite review requested due to automatic review settings August 17, 2026 11:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@DanielKellerM
DanielKellerM merged commit a181869 into pulp-platform:devel Aug 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants