Build system refactor#81
Open
clienthax wants to merge 2 commits into
Open
Conversation
Move get-config-scripts to utils folder. Add NO_SAVANNAH env flag for CI usage. Switch download hash check from md5 -> sha25. Archive links updated to ssl where possible. Replaced download script as one one was unreliable for downloads with no checksums. Made smoke test print out actual failing files. Added util script for generating seperate build steps for github actions. Added MacOS x64 and arm runners
clienthax
force-pushed
the
build-system-refactor
branch
from
5138903 to
1ffa4d3
Compare
Member
Could you expand on this please? Obviously for files that have no checksum the checksum can't be checked, but that is true of your modified version as well. The files which do not have checksums are the repo tarballs which don't have stable checksums due to how github generates them. A solution to that can be to use submodules instead, as in #49. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links need to be updated once the following are merged
ps3dev/ps3toolchain#139
ps3dev/PSL1GHT#162