ci: add a lint workflow with a check job - #3
Merged
Merged
Conversation
Lints the composite actions this repo is made of: actionlint over workflow files, yamllint over every yaml, and shellcheck over the run blocks inside action.yml (which actionlint does not look at). The job is named check because the main ruleset requires a status context of that name. The repo previously published no checks at all, so that context could never be reported and every pull request was unmergeable.
goastler
marked this pull request as ready for review
August 12, 2026 07:21
goastler
enabled auto-merge
August 12, 2026 07:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/lint.ymlwith a single job namedcheck:run:blocks inside them)run:blocks inside compositeaction.ymlfiles, via.github/scripts/lint_composite_shell.py. actionlint ignores action.yml entirely, and composite actions are what this repo is made of, so without this their shell was never linted at all. The extractor rewrites\${{ ... }}to a placeholder first, since those expressions are not shell syntax and otherwise produce a parse error in every file.The job name is not incidental: the
mainruleset requires a status context calledcheck, but the repo published no checks at all, so that context could never be reported and every PR was permanently unmergeable ("the base branch policy prohibits the merge"). This is what makes #2 mergeable.Linters run even where there is currently nothing of that kind to lint -- that is the point; it stops such code arriving unlinted later.
Two pre-existing findings surfaced and are fixed in the same commit, so the linter lands blocking and green:
rust-toolchain: three individual>> \$GITHUB_OUTPUTredirects grouped and quoted (SC2129/SC2086)npm:npm ci \${{ inputs.npm_ci_args }}given an explicitshellcheck disable=SC2086-- it must word split, so quoting it would be a behaviour change