expfmt: format OpenMetrics 2.0 float values and validate units - #969
Merged
Conversation
- Use writeOpenMetricsFloat in writeOpenMetrics20Sample and writeExemplar20 so integral floats render with .0. - Validate in.Unit against newlines and carriage returns. - Update test cases to reflect float formatting and add unit newline error tests. Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
fix-om20-values-units
branch
from
August 24, 2026 16:22
4cfb208 to
ad7021c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OpenMetrics 2.0 serialization to format integral floats correctly and validate metric units.
Changes:
- Uses OpenMetrics float formatting for samples and exemplars.
- Rejects units containing newlines or carriage returns.
- Updates serializer tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
expfmt/openmetrics_2_0_create.go |
Implements float formatting and unit validation. |
expfmt/openmetrics_2_0_create_test.go |
Updates expected output and adds unit validation tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dashpole
marked this pull request as ready for review
August 24, 2026 16:26
bwplotka
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small follow-up fixes to the OpenMetrics 2.0 support introduced by #894.