Skip to content

model: sort label names without boxing them into sort.Interface #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoloJacobs wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

model: sort label names without boxing them into sort.Interface #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions model/signature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
package model

import (
"sort"
"slices"
)

// SeparatorByte is a byte that cannot occur in valid UTF-8 sequences and is
Expand All @@ -37,7 +37,7 @@ func LabelsToSignature(labels map[string]string) uint64 {
for labelName := range labels {
labelNames = append(labelNames, labelName)
}
sort.Strings(labelNames)
slices.Sort(labelNames)

sum := hashNew()
for _, labelName := range labelNames {
Expand All @@ -60,7 +60,7 @@ func labelSetToFingerprint(ls LabelSet) Fingerprint {
for labelName := range ls {
labelNames = append(labelNames, labelName)
}
sort.Sort(labelNames)
slices.Sort(labelNames)

sum := hashNew()
for _, labelName := range labelNames {
Expand Down Expand Up @@ -100,7 +100,7 @@ func SignatureForLabels(m Metric, labels ...LabelName) uint64 {
return emptyLabelSignature
}

sort.Sort(LabelNames(labels))
slices.Sort(labels)

sum := hashNew()
for _, label := range labels {
Expand Down Expand Up @@ -129,7 +129,7 @@ func SignatureWithoutLabels(m Metric, labels map[LabelName]struct{}) uint64 {
if len(labelNames) == 0 {
return emptyLabelSignature
}
sort.Sort(labelNames)
slices.Sort(labelNames)

sum := hashNew()
for _, labelName := range labelNames {
Expand Down
Loading