Skip to content

fix(napm): report failed web redirect to backend when confirmation is required #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbashtani wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −2
Open

fix(napm): report failed web redirect to backend when confirmation is required #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...dules/NativeAlternativePayment/Interactor/NativeAlternativePaymentDefaultInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,24 @@ final class NativeAlternativePaymentDefaultInteractor:
callback: configuration.redirect.callback,
prefersEphemeralSession: configuration.redirect.prefersEphemeralSession
)
let returnUrl = try await webAuthenticationSession.authenticate(using: authenticationRequest)
redirectResult = .init(success: true, result: .init(url: returnUrl))
do {
let returnUrl = try await webAuthenticationSession.authenticate(using: authenticationRequest)
redirectResult = .init(success: true, result: .init(url: returnUrl))
} catch {
// Report failed redirect to backend, mirroring the deep link branch,
// so that invoice state doesn't remain pending when customer cancels
// or authentication session is unable to start.
if redirect.confirmationRequired {
_ = try? await serviceAdapter.continuePayment(
with: .init(
flow: configuration.flow,
redirect: .init(success: false),
localeIdentifier: configuration.localization.localeOverride?.identifier
)
)
}
throw error
}
default:
throw POFailure(errorDescription: "Unknown redirect type.", code: .Mobile.internal)
}
Expand Down