GSOC-E2E: Multi-file/Multi-folder sketch management - #4263
Open
Geethegreat wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #
Adds tests to verify multi-file and multi-folder sketch feature
Demo:
e2e-multifile.mp4
e2e-multifolder.1.mp4
Changes:
editor.spec.tscovering the multi-file sketch feature: creating additional.jsfiles, registering them inindex.htmlvia<script>tags, and running the resulting sketch.User can create a functioning sketch with multiple files: createsfileA.jsat the sketch root, wires it intoindex.html, calls it fromsketch.js, verifies it runs, then deletesfileA.jsand confirms the sketch breaks accordingly (fileA is not defined).user can create a functioning sketch with folders: same flow, butfileA.js/fileB.jslive in two separate folders (folderA,folderB) rather than side by side, to actually exercise folder-boundary resolution. After deletingfolderA, verifiesfolderB/fileB.jsis untouched, confirming folder deletion is properly scoped to just the deleted folder and its contents.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123