chore: rename js/ to pkg-js/ - #197
Merged
Merged
Conversation
- Mechanical git mv; matches the pkg-py/pkg-r sibling convention ahead of publishing @posit/shinyreact (decided for #172) - Update Makefile PATH_PKG_JS, .gitignore, pre-commit excludes, check-js workflow paths, CLAUDE.md, README, conf-2026 goals doc, and the 09-hmr dev-bridge import - Historical docs/superpowers/ plans and specs left untouched
schloerke
marked this pull request as ready for review
August 17, 2026 16:13
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196. Refs #172.
Summary
Purely mechanical rename of
js/topkg-js/so the JS package sits alongsidepkg-py/andpkg-r/in thepkg-*sibling convention, ahead of publishing it as@posit/shinyreact(decided indecisions/2026-08-17-js-distribution.md, pending on its own branch).git mv js pkg-js— all files detected as 100% renames, including the committeddist/assets.Makefile(PATH_PKG_JS, the single source for alljs-*targets),.gitignore(!pkg-js/dist/),.pre-commit-config.yamlexcludes,.github/workflows/check-js.yamltrigger paths andworking-directory,CLAUDE.md,README.md,docs/posit-conf-2026-goals.md, andexamples/09-hmr/src/shiny-bridge.dev.ts(relative import of the vendored source).docs/superpowers/intentionally left untouched.js-setup,js-build, …) are unchanged — only the directory moved.Verification
make js-lintpasses (tsc --noEmit).make js-testpasses (166 tests, 12 files).make update-distproduces zero diffs —pkg-js/dist/,pkg-py/src/shinyreact/www/, andpkg-r/inst/lib/shiny/remain byte-identical, so the check-js "no uncommitted changes" job will pass.grep -rn 'js/(src|dist)' --exclude-dir=docsfinds no remaining references outside historical docs.