Skip to content

fix: address PR #11 review feedback - #12

Merged
schloerke merged 2 commits into
mainfrom
schloerke/pr-11-threads
Mar 18, 2026
Merged

fix: address PR #11 review feedback#12
schloerke merged 2 commits into
mainfrom
schloerke/pr-11-threads

Conversation

@schloerke

Copy link
Copy Markdown
Collaborator

Addresses all 8 unresolved review threads from PR #11 (Copilot feedback):

  • Fixed async/await in 8-modules example (post_message call)
  • Updated ShinyModuleContext JSDoc to document nesting behavior
  • Clarified applyNamespace documentation for null/undefined/empty string
  • Added namespace prop documentation to ImageOutput
  • Removed debug print statement from 7-chat example
  • Fixed tailwind.css path in 5-shadcn components.json
  • Corrected 5-shadcn package.json (name, description, added private: true)
  • Fixed indentation in 8-modules srcts-standard/main.tsx

- Await async post_message() in 8-modules example
- Update ShinyModuleContext JSDoc to reflect nesting behavior
- Clarify applyNamespace docs for empty string/null/undefined
- Add namespace prop JSDoc to ImageOutput component
- Remove debug print(env_file) in 7-chat example
- Fix tailwind.css path in 5-shadcn components.json
- Fix 5-shadcn package.json name/description, add private:true
- Fix indentation in 8-modules srcts-standard/main.tsx

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@schloerke
schloerke marked this pull request as ready for review March 18, 2026 20:29
Comment thread examples/shiny-react-upstream/5-shadcn/package.json Outdated
@schloerke
schloerke merged commit 4a6e49b into main Mar 18, 2026
2 checks passed
@schloerke
schloerke deleted the schloerke/pr-11-threads branch March 18, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant