ci: add package check and address native warning - #109
Conversation
|
Preview deployed to Connect ( Deployed from commit 71be570. |
|
Preview deployed to Connect ( Deployed from commit 71be570. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux sandbox capability probe to avoid R CMD check “compiled-code” warnings by removing the _exit symbol from the forked child path, while preserving the same throwaway child-process behavior used to test user namespace support.
Changes:
- Added a small helper (
exit_probe_child()) that terminates the probe child viasyscall(SYS_exit, status). - Switched the
c_sandbox_capabilities()fork-child exit path from_exit(...)to the new helper.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1ef1d87 to
16de2c3
Compare
cpsievert
changed the title
dd1ff3b to
71be570
Compare
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Seems reasonable, thanks!
|
Cleaned up 5 preview bundle(s) on https://dogfood.team.pct.posit.it: 360754, 360755, 360759, 360760, 360764 |
|
Cleaned up 5 preview bundle(s) on https://connect.staging.pct.posit.it: 1752, 1753, 1755, 1756, 1759 |
Why this matters
This repository did not previously run
R CMD checkin GitHub Actions. The first commit adds that general package gate, and its initial Linux run exposes an existing compiled-code warning from the sandbox capability probe. The following commits remove that warning and stabilize snapshots against a new DuckDB startup notice.What changes
R CMD checkworkflow for the package suite.SYS_exit_group, avoiding the libc_exitsymbol that the compiled-code scan flags.Stacked follow-up
#107 is stacked on this PR. It introduces the browser-test helper, adds
COMMONS_SKIP_BROWSER_TESTS=trueto the inherited package-check workflow, and runs those browser tests in its own dedicated workflow. This PR deliberately contains no citation-specific browser-test policy.Verification
_exitwarning on Ubuntu.checking compiled code ... OK.Rscript -e 'devtools::test(filter = "commons")'passed all affected snapshot assertions locally; its three remaining failures are the known local macOS FTS extension-download block.\n- The previous fresh Linux run passed the package check, deploy, and pkgdown workflows; this branch rewrite has triggered the final standalone rerun.