Adding zoneid and tags - #9
Open
poddm wants to merge 5 commits into
Open
Conversation
poddm
force-pushed
the
mp/service_zoneid_tags
branch
from
August 7, 2026 22:39
0e51815 to
50bc506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
tagsfield and fixzone_idshandling for service offeringsSummary
This PR adds a
tagsattribute to the service offering resources and fixes a bug wherezone_idswas incorrectly overwritten when the CloudStack API returned"all"as the zone ID.Changes
New
tagsfieldtagsas an optionalStringAttributeto the common service offering schemaTagsfield toserviceOfferingCommonResourceModelapplyTags()helper that sets tags onCreateServiceOfferingParamswhen non-nullFix
zone_idsstate managementcommonReadandcommonUpdatenow skip overwritingZoneIdswhen the API returns"all"or an empty string — previously this would replace anull/empty plan value with["all"], causing a perpetual diffcommonUpdateParamsandcommonCreateParams: extractedzoneIDslocal variable for clarity; no behavioral changeFiles Changed
service_offering_models.goTagsfieldservice_offering_schema.gotagsschema attributeservice_offering_util.gozone_ids"all" handling; addapplyTags()service_offering_{fixed,constrained,unconstrained}_resource.go