fix(sdks): align order book field types#1417
Conversation
PR Review: PASS (NOT VERIFIED)What This DoesAdds missing SDK model fields for order book metadata that core/OpenAPI already expose: per-level Blast RadiusSDK model type surfaces only: Consumer VerificationBefore (base branch): After (PR branch): Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- additive SDK type/model declarations for fields already exposed by core/OpenAPI responses. RiskFull package build and generated-client verification were not possible because generated SDK artifacts are missing in the checkout; this review therefore verifies the hand-written model surfaces and existing schema/core presence, not a packaged SDK build. |
Summary
orderCountto TypeScriptOrderLevelandorder_countto PythonOrderLevel.isNegRisk,lastTradePrice, andsourceMetadatato TypeScriptOrderBook.is_neg_risk,last_trade_price, andsource_metadatato PythonOrderBook.Fixes #1392
Fixes #1393
Fixes #1394
Fixes #1395
Test Plan
python3 -m py_compile sdks/python/pmxt/models.py sdks/python/pmxt/client.pygit diff --checkNote: local TypeScript compiler validation was blocked in this fresh worktree because
node_modules/.bin/tscis not installed; GitHub generated-sync/CodeQL checks will validate the committed TypeScript surface.