fix(ts-sdk): forward apiSecret credentials#1375
Conversation
PR Review: PASS (NOT VERIFIED)What This DoesThis adds Blast RadiusTypeScript SDK base client credential plumbing only: all TS SDK exchange subclasses inherit Consumer VerificationBefore (base branch): A TS SDK consumer could not express After (PR branch): export interface ExchangeOptions { apiSecret?: string; }
protected apiSecret?: string;
this.apiSecret = options.apiSecret;
...
return {
apiKey: this.apiKey,
apiSecret: this.apiSecret,
privateKey: this.privateKey,
funderAddress: this.proxyAddress,
signatureType: this.signatureType,
};The added test exposes Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- fixes missing TS SDK credential forwarding without changing existing public behavior. RiskRuntime verification through a compiled TypeScript SDK and actual sidecar request body remains unverified in this environment because generated TS artifacts are absent and OpenAPI generation requires Java, which is not installed here. |
Summary
apiSecretto TypeScriptExchangeOptionsand stores it onExchange.apiSecretin sidecar credentials so Polymarket, Limitless, Probable, and GeminiTitan can receive the secret expected by core.Fixes #1371
Test Plan
npm test -- --runTestsByPath tests/exchange-credentials.test.ts --runInBandnpm test -- --runTestsByPath tests/sidecar-order-param-forwarding.test.ts tests/hosted-order-params-types.test.ts tests/exchange-credentials.test.ts --runInBandnpx tsc --noEmitNote: local TypeScript SDK tests/build needed an untracked minimal
sdks/typescript/generated/src/index.tsstub because generated SDK artifacts are absent in this focused checkout; the stub was not staged or committed.