fix(python-sdk): route order-book unwatch via HTTP#1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unwatch_order_bookthrough the sidecar HTTPunwatchOrderBookendpoint, matching TypeScript andunwatch_addressbehavior.Fixes #1315
Test Plan
PYTHONPATH=/tmp/pmxt_test_stubs:sdks/python uv run --no-project --with pytest --with pydantic --with python-dateutil --with 'urllib3>=2.7.0' --with typing-extensions python -m pytest sdks/python/tests/test_streaming_ws_transport.py::test_unwatch_order_book_uses_http_sidecar_transport -qPYTHONPATH=/tmp/pmxt_test_stubs:sdks/python uv run --no-project --with pytest --with pydantic --with python-dateutil --with 'urllib3>=2.7.0' --with typing-extensions python -m pytest sdks/python/tests/test_streaming_ws_transport.py -qpython3 -m py_compile sdks/python/pmxt/client.py sdks/python/tests/test_streaming_ws_transport.pyNote: the committed checkout does not include generated
pmxt_internalartifacts, so local pytest used a temporary untracked minimal/tmp/pmxt_test_stubs/pmxt_internalstub for imports only; the exercised code path is the hand-maintained SDK wrapper.