Skip to content

fix(python-sdk): route order-book unwatch via HTTP#1324

Merged
realfishsam merged 1 commit into
mainfrom
fix/issue-1315-python-unwatch-http
Jun 27, 2026
Merged

fix(python-sdk): route order-book unwatch via HTTP#1324
realfishsam merged 1 commit into
mainfrom
fix/issue-1315-python-unwatch-http

Conversation

@realfishsam

Copy link
Copy Markdown
Contributor

Summary

  • Routes Python unwatch_order_book through the sidecar HTTP unwatchOrderBook endpoint, matching TypeScript and unwatch_address behavior.
  • Updates the streaming transport regression test so order-book unwatch no longer requires an active WebSocket client.

Fixes #1315

Test Plan

  • PYTHONPATH=/tmp/pmxt_test_stubs:sdks/python uv run --no-project --with pytest --with pydantic --with python-dateutil --with 'urllib3>=2.7.0' --with typing-extensions python -m pytest sdks/python/tests/test_streaming_ws_transport.py::test_unwatch_order_book_uses_http_sidecar_transport -q
  • PYTHONPATH=/tmp/pmxt_test_stubs:sdks/python uv run --no-project --with pytest --with pydantic --with python-dateutil --with 'urllib3>=2.7.0' --with typing-extensions python -m pytest sdks/python/tests/test_streaming_ws_transport.py -q
  • python3 -m py_compile sdks/python/pmxt/client.py sdks/python/tests/test_streaming_ws_transport.py

Note: the committed checkout does not include generated pmxt_internal artifacts, so local pytest used a temporary untracked minimal /tmp/pmxt_test_stubs/pmxt_internal stub for imports only; the exercised code path is the hand-maintained SDK wrapper.

@realfishsam realfishsam merged commit 1cd1b87 into main Jun 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK drift: Python unwatch_order_book routes via WebSocket; TypeScript unwatchOrderBook uses HTTP POST

1 participant