Skip to content

fix(core): use Rain contract address for price history#1300

Merged
realfishsam merged 1 commit into
mainfrom
fix/rain-price-history-1193
Jun 24, 2026
Merged

fix(core): use Rain contract address for price history#1300
realfishsam merged 1 commit into
mainfrom
fix/rain-price-history-1193

Conversation

@realfishsam

Copy link
Copy Markdown
Contributor

Summary

  • Resolve Rain outcome market ids to on-chain contract addresses before fetching OHLCV.
  • Call the Rain SDK getPriceHistory with marketAddress, interval, and option instead of silently ignored marketId/optionIndex/limit keys.
  • Add focused regression coverage for both the fetcher parameter contract and exchange-level market-id resolution.

Fixes #1193

Test Plan

  • npm test --workspace=pmxt-core -- --runInBand core/test/exchanges/rain-fetcher.test.ts
  • npm run build --workspace=pmxt-core

@realfishsam

Copy link
Copy Markdown
Contributor Author

Verified in this low-hanging PR automation run: GitHub required checks are green; locally ran npm test --workspace=pmxt-core -- --runInBand core/test/exchanges/rain-fetcher.test.ts (2 tests passed) and npm run build --workspace=pmxt-core (passed).

@realfishsam realfishsam merged commit 82020f9 into main Jun 24, 2026
12 checks passed
@realfishsam realfishsam deleted the fix/rain-price-history-1193 branch June 24, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spec-drift/rain: getPriceHistory param mismatch — PMXT passes marketId/optionIndex/limit but SDK expects marketAddress/option with no limit param

1 participant