Add throttle-app, unthrottle-app, and app-metrics to vtctld throttler update-config - #1313
Open
maxenglander wants to merge 3 commits into
Open
Add throttle-app, unthrottle-app, and app-metrics to vtctld throttler update-config#1313maxenglander wants to merge 3 commits into
maxenglander wants to merge 3 commits into
Conversation
… update-config. Matches Inventory2 Staging Runbook vtctldclient UpdateThrottlerConfig flags so those steps can run via pscale without pskube. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com>
…t defaults. vtctldclient allows keyspace-only calls and uses ratio 1.0 / duration 1h defaults. Use cobra MarkFlagsMutuallyExclusive / RequiredTogether for the same flag constraints. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
marked this pull request as ready for review
July 28, 2026 21:20
dgraham
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
pscale branch vtctld throttler update-configonly exposed--keyspace,--enabled(required), and--threshold. Per-app throttle, unthrottle, and app-checked metrics still needed rawvtctldclient.Solution:
--enabledoptional.--throttle-app,--throttle-app-ratio,--throttle-app-duration,--unthrottle-app,--app-name,--app-metrics.Depends on: planetscale/planetscale-go#331 (API surface; CLI keeps its vendored client)
Example:
Testing:
Made with Cursor