Add Erticaz Press theme (themes/erticazPress) v1.0.0#497
Open
haydary1986 wants to merge 2 commits into
Open
Conversation
A free, GPL-3.0 institutional OJS theme with full RTL support (EN/AR/TR). Release package + MD5 verified. https://github.com/haydary1986/erticaz-press-ojs-theme Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Thanks, @haydary1986! At a glance it looks like you may need to escape some of the theme settings to prevent XSS injection; see e.g. https://github.com/pkp/pkp-lib/issues/11974 for similar changes needed for similar changes made to another theme. |
Addresses the XSS/CSS-injection review note (pkp/pkp-lib#11974): strict hex colour validation, strip_tags on free-text settings, and all settings escaped on output. Also adds configurable facts, 6 locales and accessibility support. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Thanks for the quick and helpful review, @asmecher! 🙏 You're right. I've audited every theme setting and hardened them against CSS/XSS injection, following the approach in pkp/pkp-lib#11974:
These fixes are published as v1.1.0, and I've updated this PR to point to the new release (new package URL + MD5): Thanks again for maintaining the gallery and for the careful review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new theme: Erticaz Press
This PR adds Erticaz Press, a free, open-source (GPL-3.0) institutional theme for OJS.
themes· Product:erticazPress5040cce2049a85976a6dca45124217a6About the theme
A child of the OJS Default theme that gives any journal a clean, institutional (Elsevier/Springer-style) look: a full-width home page with an institutional masthead, a key-facts band, an indexing & abstracting grid and a title-only current-issue list, plus comprehensive styling for every sub-page (article, archive, search, announcements, forms, pagination, masthead). One-colour palette system, full RTL support and bundled English / Arabic / Turkish locales.
The new
<plugin>entry is appended at the end ofplugins.xmland is well-formed; the release URL is live and its MD5 matches the file above.Thank you for maintaining the gallery! 🙏