Fix FIFO verifier masking in corpus scores#119
Merged
Conversation
luisleo526
marked this pull request as ready for review
July 17, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The old duplicate-entry guard also matched ordinary margin-call fragments and could replace per-trade PnL error with whole-window net PnL. In the downstream 402-strategy board this falsely inflated two tiers: z8830 Excellent to Strong after correction, and Van VWAP Strong to Moderate. The corrected board is 346 Excellent / 47 Strong / 4 Moderate / 5 Weak. The public engine corpus remains 246 Excellent / 5 Strong / 1 Anomaly.
Validation