Fix drawing state and lexical series identity#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
na, drawing history, and cloned call-site storage across generated C++ state.request.securityinitialization semantics covered by the consolidated validation suite.Why
Several independently correct-looking name-based rewrites could combine to hide a semantic miscompile. Raw identifier unions and call-site remaps were conflating distinct lexical bindings, especially when drawing handles, persistent callable locals, parameters, loops, and tuple destructuring reused names. The generated program could compile and still read or write the wrong series state.
This patch makes storage selection declaration-aware and adds permanent adversarial coverage for the previously masked combinations.
Validation
1976 passed, 2 skipped, 0 failed.277/277classified as expected (263 OK + 14 expected errors), CPython/WASM parity green.8/8cells passed for callable persistent siblings, series-parameter isolation, and lexical binder identity.32/32cells passed.32/32cells passed.408 OK + 7 expected outcomes, no compile/driver/timeout failures, no tier downgrades.Excellent 352 / Strong 47 / Moderate 4 / Weak 3; this milestone is a semantic-correctness fix rather than a score-only change.