Skip to content

fix(codegen): route array percentrank keywords#71

Merged
luisleo526 merged 1 commit into
mainfrom
fix/ki48d-percentrank-keywords
Jul 17, 2026
Merged

fix(codegen): route array percentrank keywords#71
luisleo526 merged 1 commit into
mainfrom
fix/ki48d-percentrank-keywords

Conversation

@luisleo526

Copy link
Copy Markdown
Contributor

Summary

  • register the index parameter for array.percentrank keyword merging
  • support namespace all-keyword (including reversed keyword order), namespace mixed, global identifier method, and arbitrary-expression method forms
  • preserve receiver-before-index one-evaluation behavior through the existing checked PercentRank lowering

This does not broaden PercentRank semantics. Array-typed UDF parameter method dispatch is a separate pre-existing receiver-routing residual; its positional form is also currently unsupported.

Validation

  • engine-enabled pytest: 1,701 passed / 2 skipped
  • focused keyword/native runtime: 6/6
  • native/Pyodide differential: 277/277 (263 accepted, 14 expected rejects)
  • positional frozen manifest: 666/666 byte-identical, 660 OK / same 6 errors
  • sole positional consumer generated C++ therefore remains byte-identical; no trade replay change is possible
  • independent review: approved, no scoped blockers
  • git diff --check

@luisleo526
luisleo526 marked this pull request as ready for review July 17, 2026 20:41
@luisleo526
luisleo526 merged commit 1807df0 into main Jul 17, 2026
9 checks passed
@luisleo526
luisleo526 deleted the fix/ki48d-percentrank-keywords branch July 17, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant