Fix NAT keepalive dropped by src-binding; flow poll retry; recover test#303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the multi-agent scrub of the verified-badges work.
HIGH — NAT keepalive regression (from #294). The transport src-binding check drops frames whose inner
Src.Node!= the AEAD-authenticated peer, butkeepaliveSweepbuilt the keepalive withSrc.Nodeunset (0) — so every NAT keepalive was dropped at the receiver and mappings expired (reintroducing the v1.9.1 bug). Fix:newKeepalivePacketnow stamps our own node id (= the peer id from the receiver's view). Extracted to a helper + addedTestKeepalivePacketStampsOwnSourcethat exercises the real shape (the old test hand-crafted the packet and masked this).MED — device-flow poll resilience.
pilotctl verify --provideraborted the whole flow on a single transient poll error; now tolerates up to 5 consecutive failures before giving up.MED — recover coverage. Added
TestCmdRecoveryRecoverInstallsNewIdentityfor the most destructive command (keyless force-rotate + local identity install).go test -racegreen on pkg/daemon + cmd/pilotctl; gofmt + vet clean.