Bump common to v0.5.3 (pinned badge issuer key)#298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up common v0.5.3, which pins the production badge issuer key (bdg-v1). With this, a locally-built
pilotctl verify status/ daemon verifies real badges offline against the pinned key instead of failing closed on the placeholder.go.mod/go.sum only. Build green (
go build ./...); badge handler + verify-status tests pass against the real key (a forged sig still correctly fails verification).Note: this is the CLIENT side only. Prod rendezvous stays INERT — the registry won't accept/serve real badges until it's rebuilt on v0.5.3 and you give the go-live.