Skip to content

fix(telemetry): default daemon to production endpoint; emit app_usage on pilotctl call #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 2 commits into from
Jun 21, 2026
+16 −1
Merged

fix(telemetry): default daemon to production endpoint; emit app_usage on pilotctl call #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a0f1d
fix(telemetry): default daemon to production endpoint; emit app_usage…
teovl Jun 21, 2026
67dac2b
Merge branch 'main' into fix/telemetry-daemon-default-and-call-usage
Alexgodoroja Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/daemon/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ func main() {
sandboxDir := flag.String("sandbox-dir", "", "confinement root when -sandbox is set (default: ~/.pilot)")
motdFeedURL := flag.String("motd-feed-url", motd.DefaultFeedURL, "message-of-the-day feed URL (empty to disable); overridden by $PILOT_MOTD_URL")
motdInterval := flag.Duration("motd-interval", 0, "message-of-the-day poll interval (default 15m)")
telemetryURL := flag.String("telemetry-url", os.Getenv("PILOT_TELEMETRY_URL"),
telemetryURLDefault := os.Getenv("PILOT_TELEMETRY_URL")
if telemetryURLDefault == "" {
telemetryURLDefault = telemetry.DefaultEndpoint
}
telemetryURL := flag.String("telemetry-url", telemetryURLDefault,
"telemetry endpoint URL (empty = consent off, hard no-op). "+
"Env: PILOT_TELEMETRY_URL. Default: "+telemetry.DefaultEndpoint+".")
flag.Parse()
Expand Down
11 changes: 11 additions & 0 deletions cmd/pilotctl/appstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2076,6 +2076,17 @@ func cmdAppStoreCall(args []string) {
fatalHint("ipc_error", hint, "%v", err)
}

// Emit app_usage telemetry for a successful call (consent-gated, best-effort).
if h, _ := os.UserHomeDir(); consent.GetConsent(h, "telemetry") {
turl := os.Getenv("PILOT_TELEMETRY_URL")
if turl == "" {
turl = telemetry.DefaultEndpoint
}
payload, _ := json.Marshal(map[string]string{"app_id": appID, "method": method})
client := telemetry.NewClientFromIdentity(turl, configDir()+"/identity.json", nodeIDFromDaemon())
_ = client.Send(telemetry.Event{Kind: "app_usage", Payload: json.RawMessage(payload)})
}

// Maybe replace the real result with a review prompt (gated by
// appstore.review_prompt feature flag + random roll).
replaced, intercepted := maybeInterceptOutput(result, appID)
Expand Down
Loading