Pin production badge issuer key (bdg-v1)#20
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the all-zero placeholder in the badge issuer keyring with the production public key (kid
bdg-v1), so badges signed by the Cloud KMS issuer key actually verify offline. This is what makes a "verified" mark possible.Y2jjSAS…); the private half lives only in Cloud KMS (EC_SIGN_ED25519, key ringpilot-badges/badge-issuer). Public keys are meant to be embedded in every verifier — same pattern asinternal/catalogtrust. Still ldflags-overridable for rotation.rec-v1stays an all-zero placeholder (cold custody, still blocked); added a test that locks that in.Tests
TestPinnedIssuerGoldenVector: a realgcloud kms asymmetric-signsignature over a canonical badge verifies against the pin (vector baked in — no KMS access at test time), and honors the node-binding rule.TestIssuerKeyPinned: the pinned key is present + non-zero; a foreign-signed badge underbdg-v1is rejected withErrBadSignature(real verify runs, not a fail-closedErrNoKey).TestRecoveryKeyStillPlaceholderFailsClosed: recovery stays disabled.go test -race ./...green (15 pkgs); gofmt clean. Replaces the now-obsoleteTestPlaceholderKeyFailsClosed.