Add driver SubmitBadge and EnrollRecovery client methods#19
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two optional client-side driver methods completing the verified-address badge feature's client layer:
Driver.SubmitBadge(badge, badgeSig)— IPC cmd 0x2F/0x30Driver.EnrollRecovery(enrollment, enrollmentSig)— IPC cmd 0x31/0x32Both forward verifier-produced credentials to the daemon, which signs proof of the current key and calls the matching registry-client method (shipped in v0.5.1). The raw external identity never crosses this layer — only the badge / opaque commitment.
Also allowlists the two new response opcodes in the client readLoop; without that, replies are silently dropped and every call hangs (caught by the new tests).
Tests:
go test -race ./driver/green; gofmt clean.