feat(driver): PreferDirect IPC command + driver method#15
Merged
Conversation
Adds the cmd_prefer_direct IPC opcode and Driver.PreferDirect(nodeID), letting pilotctl ask the daemon to drop a peer's tunnel + cached resolution so the next dial re-runs the full resolve + NAT hole-punch flow and prefers the direct path. Used by `pilotctl prefer-direct` and `send-file --prefer-direct`. Backward compatible: old daemons reply "unknown command", which the client treats as a best-effort hint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the cmd_prefer_direct IPC opcode and Driver.PreferDirect(nodeID). Lets pilotctl ask the daemon to drop a peer's tunnel + cached resolution so the next dial re-runs resolve + NAT hole-punch and prefers direct. Backward compatible (old daemons reply 'unknown command'). Part of the v1.11.1 NAT-reliability work (web4 PR #247, dataexchange PR #22). Held for review — not tagged.