publish: bundles is a v2-optional field, never bump catalogue to v3#27
Merged
Conversation
pilotctl loadCatalogue fail-closes on any version != 1 && != 2 (the catalogue's design is optional fields + forward/backward compat, no version bump). The multi-platform pipeline bumped to version 3 when it wrote a bundles map, which would make EVERY client reject the whole catalogue. Keep version 2 and add bundles as an optional field. Verified: a stock v1.12.1 client installs the darwin/arm64 bundle from a v2+bundles catalogue (the macOS-silicon fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
pilotctl'sloadCataloguefail-closes on any catalogueversion != 1 && != 2:But
publish-submission.sh(from the multi-platform PR #24) bumped the catalogue to version 3 whenever it wrote abundlesmap. A v3 catalogue is therefore rejected wholesale by every client —resolveBundleis never even reached. This is why Sixtyfour's macOS-silicon install fails: the multi-platform logic exists but a v3 catalogue can't load.The fix
bundlesis an optional v2 field, exactly per the catalogue's stated design ("v2 only adds optional fields … forward AND backward compatible by construction"). Keepversion: 2and addbundlesas a field. No version bump.bundles, usebundle_url(so single-platform still works; macOS needs v1.12.x).bundlesviaresolveBundle, pick the host's platform.Verified live
Built a stock v1.12.1 pilotctl (test trust key), pointed it at a v2+bundles catalogue, ran
appstore install io.pilot.sixtyfouron macOS arm64 → it fetched the darwin-arm64 bundle (not linux), installed, ran, and returned real data through the broker (mbenioff@salesforce.com, cost 5¢).