Upgrade PHPBench to 1.7.0 and use aggregate-preview report#6067
Merged
Conversation
Updates PHPBench to 1.7.0 and use the unstable "aggregate-preview" report that currently includes the _diff_ column.
Contributor
|
lets give it a try, thank you @dantleech |
Contributor
|
@dantleech looking at the CI result in https://github.com/phpstan/phpstan-src/actions/runs/29727370175/job/88303447395 it seems the result table misses the "diff" column? or maybe I need to regenerate the baseline for the new version? |
Contributor
Author
|
@staabm that run is prior to this PR being merged. I guess it's still runninng ... or .. I don't know 🤔 |
Contributor
Author
|
ah the run conditions were not triggered: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates PHPBench to 1.7.0 and use the unstable "aggregate-preview" report (which may have minor changes prior to a 2.0 release). The "preview" report includes a
diffcolumn.cc @staabm