Fixing bugs - #320
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds host timezone propagation into newly created phpBB sandbox boards (and into the generated Docker runtime), and improves extension uninstall behavior by purging phpBB cache after an extension is purged.
Changes:
- Detect host timezone in
BoardServiceand store it asboard_timezonein board metadata/runtime config. - Pass
QUICKINSTALL_BOARD_TIMEZONEinto docker-compose and set phpBB’sboard_timezoneduring first-time install with a PHP runtime compatibility fallback to UTC. - Purge phpBB cache after uninstalling an extension (and update unit tests accordingly).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/DockerComposeWriterTest.php | Asserts timezone env + entrypoint timezone-setting logic is present in generated runtime files. |
| tests/Unit/BoardServiceTest.php | Verifies board metadata includes board_timezone and adds coverage for TZ environment handling. |
| tests/Unit/BoardRunnerTest.php | Updates expectations to include cache purge after extension uninstall. |
| src/QuickInstall/Sandbox/DockerComposeWriter.php | Adds timezone env var and entrypoint logic to apply board timezone with UTC fallback. |
| src/QuickInstall/Sandbox/BoardService.php | Introduces host timezone detection and persists it into board config/metadata. |
| src/QuickInstall/Sandbox/BoardRunner.php | Purges cache after extension purge to clear compiled artifacts. |
| src/QuickInstall/Sandbox/BoardRefreshService.php | Adds board_timezone to runtime config defaults used during refresh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'admin_pass' => 'password', | ||
| 'admin_email' => 'admin@example.test', | ||
| 'board_email' => 'board@example.test', | ||
| 'board_timezone' => 'UTC', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.