Fix case where installed path is symlink - #33
Merged
Conversation
Contributor
Author
|
I wasn't able to come up with a proper test setup |
One can install packages from a local path via composers repositories type "path". Those are typically symlinks which were not resolved. We therefore add a realpath() call, but falling back to old behavior if it didn't resolve. That way we keep independent of realpath() as requested by the inline comment. Resolves: phpactor/phpactor#2727
d-s-codappix
force-pushed
the
2727-support-linked-files
branch
from
August 4, 2026 09:51
06b218f to
4d6d2d1
Compare
Contributor
Author
|
I finally found the time to come up with a test case. |
Contributor
Author
|
The failing tests reported by https://github.com/phpactor/class-to-file/actions/runs/30898115673/job/91955766437?pr=33 already failed for me on current |
Collaborator
|
looks good, thanks. will look at the failing tests in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can install packages from a local path via composers repositories type "path".
Those are typically symlinks which were not resolved. We therefore add a realpath() call, but falling back to old behavior if it didn't resolve. That way we keep independent of realpath() as requested by the inline comment.
Resolves: phpactor/phpactor#2727