Skip to content

Fix php_embed_ub_write() infinite loop on failed write #23427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 1 commit into
base: PHP-8.2
Choose a base branch
from
Open

Fix php_embed_ub_write() infinite loop on failed write #23427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.2.34

- Embed:
. Fixed bug GH-23423 (php_embed_ub_write() infinite loop when a write
fails and the connection is not aborted). (Lazizbek Ergashev)

30 Jul 2026, PHP 8.2.33

Expand Down
1 change: 1 addition & 0 deletions sapi/embed/php_embed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ static size_t php_embed_ub_write(const char *str, size_t str_length)
ret = php_embed_single_write(ptr, remaining);
if (!ret) {
php_handle_aborted_connection();
return str_length - remaining;
}
ptr += ret;
remaining -= ret;
Expand Down
Loading