Skip to content

Update tables to fix mobile labels - #5785

Open
pwright64 wants to merge 2 commits into
php:masterfrom
pwright64:master
Open

Update tables to fix mobile labels#5785
pwright64 wants to merge 2 commits into
php:masterfrom
pwright64:master

Conversation

@pwright64

Copy link
Copy Markdown

Moved "properties" and "methods" to table titles from table entries, splitting tables at these points; removed class names from table entries; and updated table id's to match new tables. This fixes the following issue: On mobile, table is collapsed and table head entries are used as :before label elements for table body entries, in a cycling fashion (see web-php/public/js/common.js line 835-851). Table had class names as head entries and "methods" and "properties" as body entries, resulting in incorrect labels for body entries.

Moved "properties" and "methods" to table titles from table entries (splitting tables at these points), removed class names from table entries, updated table id's to match new tables. This fixes following issue: On mobile, table is collapsed and table head entries are used as :before label elements for table body entries, in a cycling fashion (see web-php/public/js/common.js line 835-851). Table had class names as head entries and "methods" and "properties" as body entries, resulting in incorrect labels for body entries.
removed trailing whitespaces from previous commit
@kamil-tekiela

Copy link
Copy Markdown
Member

Thank you for this PR. However, I propose an alternative: remove this page altogether. I don't know why we have it. It's often out of sync with the rest of the manual. The individual pages for each class are better. I suppose it was for people using only the procedural style functions, but I don't think even they would find this page very useful. The DateTime extension has this done a bit differently https://www.php.net/manual/en/book.datetime.php. Perhaps we should do something similar in mysqli: list all functions as aliases of the methods and link to their pages without a table or description.

@kamil-tekiela

Copy link
Copy Markdown
Member

On top of that, we have this page https://www.php.net/manual/en/ref.mysqli.php confusingly named and equally useless. Are they all the aliases available? Are they all deprecated? No, it's neither.

@pwright64

Copy link
Copy Markdown
Author

I see what you're saying, and that explains why I had trouble finding an analogous page to compare with. So: getting rid of this page, splitting the alias and deprecated section into functions and deprecated, and adding the missing functions pages, seems like a sensible course of action. If it's helpful, I could work on creating pages for the procedural functions as aliases with links to the OOP pages, like the date/time page. Although that practice seems wasteful. It would be nice if we could use symlinks or redirects instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants