Do not mark do-not-translate files not translated - #339
Merged
Conversation
Member
Author
|
Updated with full do not translate support. Tested on all languages. Identical results, aside fixing files marked do-not-translate, not in translations, and yet showing in the revcheck list / database. Some languages the time of calculations is reduced by half. |
Member
Author
|
Merged, tested. All languages are ok. Most active languages converged to the correct status even with the misleading revcheck. Languages now can reach 100% again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files marked do-not-translated are showing in revcheck even if they are not present in translations. This is a small fix for that.
The full and correct fix, to detect and mark do-not-translate files present in translations, will need a wider change, as to avoid performance regressions.
Plan to merge this in one week, Reviews and commits welcome.