Skip to content

Allow Symfony 8.x#190

Merged
bocharsky-bw merged 3 commits into
php-translation:masterfrom
BenoitLeveque:allow-symfony-8
Jun 23, 2026
Merged

Allow Symfony 8.x#190
bocharsky-bw merged 3 commits into
php-translation:masterfrom
BenoitLeveque:allow-symfony-8

Conversation

@BenoitLeveque

Copy link
Copy Markdown
Contributor

No description provided.

@bocharsky-bw bocharsky-bw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Comment thread .github/workflows/ci.yml Outdated
@bocharsky-bw

Copy link
Copy Markdown
Member

I approved the build, and it seems now we have PHP CS Fixer failing. Could you also fix it here, please?

@BenoitLeveque

Copy link
Copy Markdown
Contributor Author

i've bumped the php version used by php-cs-fixer and phpstan. and i've fixed the remaining error. so we should be ok now

@bocharsky-bw bocharsky-bw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for all your changes!

@bocharsky-bw bocharsky-bw merged commit 14c16dc into php-translation:master Jun 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants