Conversation
Video (mp4, m4v, webm, ogv, mov, mkv) and audio (mp3, wav, ogg, m4a, flac, aac, aif, aiff) files now open in a media preview pane modeled on ImageViewer, instead of raw text / binary error. Shows dimensions (video), duration and file size with native playback controls. Content is loaded as a base64 data URI because blob: URLs are rejected by Chromium's media loader on the native app protocol. Files over the 16MB read cap and undecodable codecs show a friendly error message. mp4 moved out of the 'Other Binary' language into a new 'video' language; m4a/flac/aac added to 'audio'. Adds video/audio suites to mainview:MainViewFactory integ tests with tiny generated fixtures.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video (mp4, m4v, webm, ogv, mov, mkv) and audio (mp3, wav, ogg, m4a, flac, aac, aif, aiff) files now open in a media preview pane modeled on ImageViewer, instead of raw text / binary error. Shows dimensions (video), duration and file size with native playback controls.
Content is loaded as a base64 data URI because blob: URLs are rejected by Chromium's media loader on the native app protocol. Files over the 16MB read cap and undecodable codecs show a friendly error message.
mp4 moved out of the 'Other Binary' language into a new 'video' language; m4a/flac/aac added to 'audio'.
Adds video/audio suites to mainview:MainViewFactory integ tests with tiny generated fixtures.