Skip to content

fix(pkg): remove trailing quote from Windows ProductVersion - #10250

Open
byshy wants to merge 1 commit into
pgadmin-org:masterfrom
byshy:fix/10235-windows-product-version-trailing-quote
Open

fix(pkg): remove trailing quote from Windows ProductVersion#10250
byshy wants to merge 1 commit into
pgadmin-org:masterfrom
byshy:fix/10235-windows-product-version-trailing-quote

Conversation

@byshy

@byshy byshy commented Aug 12, 2026

Copy link
Copy Markdown

Summary

Test plan

  • Rebuild the Windows installer package
  • Confirm (Get-Item '...\runtime\pgAdmin4.exe').VersionInfo.ProductVersion reports a clean version (e.g. 9.17) with no trailing "
  • Confirm File Explorer → Properties → Details shows the same clean Product version

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the product version command used during application packaging.
    • Ensured version information is recorded correctly without an extra quotation mark.

rcedit was passed "%APP_VERSION%"", which stamped ProductVersion as
e.g. 9.17" on Windows installer builds.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 63692bd3-a9db-4e9c-8495-fc72ea9dcbd4

📥 Commits

Reviewing files that changed from the base of the PR and between 067f7af and 8a7a02e.

📒 Files selected for processing (1)
  • Make.bat

Walkthrough

The Windows packaging command now passes APP_VERSION to rcedit with balanced quotation marks.

Changes

Windows product version fix

Layer / File(s) Summary
Balance product version quoting
Make.bat
The rcedit command no longer adds an extra trailing quotation mark to the executable product version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: asheshv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes removal of the trailing quote from the Windows ProductVersion value.
Linked Issues check ✅ Passed The change removes the extra quote from the rcedit ProductVersion argument and directly addresses issue #10235.
Out of Scope Changes check ✅ Passed The pull request changes only the Make.bat command required to correct the Windows ProductVersion value.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@byshy
byshy marked this pull request as ready for review August 12, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgAdmin4.exe Version Number - Trailing " - Windows Installer

1 participant