Gate external auth providers behind SERVER_MODE on Desktop Mode - #10240
Open
dev-hari-prasad wants to merge 1 commit into
Open
Gate external auth providers behind SERVER_MODE on Desktop Mode #10240dev-hari-prasad wants to merge 1 commit into
dev-hari-prasad wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe authentication registry now loads only internal authentication in desktop mode. In server mode, it loads and registers configured external providers. New tests verify module imports, registry state, and provider registration for both modes. ChangesAuthentication loading gates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate external authentication providers (
kerberos,ldap,mfa,oauth2,webserver) behindconfig.SERVER_MODE. Desktop mode (SERVER_MODE = False) now only imports and registersinternalauthentication, avoiding unnecessary module overhead at startup.Changes
web/pgadmin/authenticate/registry.py: Gate external auth imports &init_appinsideload_modules()withif config.SERVER_MODE:.web/pgadmin/authenticate/tests/test_auth_gating.py: Added unit tests verifying external providers are not imported in desktop mode and are loaded in server mode.Verification & Performance
pytest2/2 PASSED,pycodestyle0 errors.load_modules()execution dropped from ~138 ms (Server Mode) to < 1 ms (Desktop Mode).Partially addresses #10221
Summary by CodeRabbit
Bug Fixes
Tests