Fix null array offset deprecation on PHP 8.5 in Select::getRawValue()#14
Open
thedotedge wants to merge 1 commit into
Open
Fix null array offset deprecation on PHP 8.5 in Select::getRawValue()#14thedotedge wants to merge 1 commit into
thedotedge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 8.5,
Select::getRawValue()triggers:at
HTML/QuickForm2/Element/Select.php:183. When a select's value isnull(e.g. an empty/unselected option, or a datasource returningnull), the loop does$this->possibleValues[$value]with$value === null, usingnullas an array offset.This casts
$valueto string in the offset lookup.nullbecomes''— which PHP already coerced it to implicitly when used as an array key — so behavior is unchanged on all supported PHP versions, and the 8.5 deprecation no longer fires. (Numeric option values are unaffected:(string) 5and5resolve to the same array key.)This deprecation is fatal under strict mode, so any form containing a
<select>fails to render on PHP 8.5.